fix: Serialize AlwaysTrue/AlwaysFalse as boolean literals#2780
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Nov 25, 2025
Merged
fix: Serialize AlwaysTrue/AlwaysFalse as boolean literals#2780kevinjqliu merged 1 commit intoapache:mainfrom
kevinjqliu merged 1 commit intoapache:mainfrom
Conversation
kevinjqliu
approved these changes
Nov 25, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! great catch.
Looks like we'd also want to fix this in the REST spec. For example,
https://github.com/apache/iceberg/blob/a3c538f647a113cf61dbfd7855d9c71da8c722ba/open-api/rest-catalog-open-api.yaml#L2243-L2246
and
https://github.com/apache/iceberg/blob/a3c538f647a113cf61dbfd7855d9c71da8c722ba/open-api/rest-catalog-open-api.yaml#L2266-L2273
Contributor
|
Only json boolean is allowed, not string "true". This is gated by the |
Contributor
|
Corresponding PR to fix in the REST spec, apache/iceberg#14677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2775
Rationale for this change
This PR aligns the
AlwaysTrueandAlwaysFalseexpression serialization to use the boolean primitivestrue/falseinstead of string representation, matching the Iceberg ExpressionParser.I know the spec defines the true/false expressions as string but today we can't hit the scan planning client endpoint following these models.
I know the spec defines the true/false expressions as a string representation, but currently we can't successfully use the scan planning client endpoint with those models. Java's actual implementation serializes these as boolean literals.
For instance, with what we have today we would throw an illegal argument exception:
Throws:
java.lang.IllegalArgumentException: argument "content" is nullBut, this works just fine (notice no quotes):
Are these changes tested?
Yes
Are there any user-facing changes?
No, this only affects the JSON serialization format to match Java Cores behavior.